Fix interaction between by-name implicits and inlining #6404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The construction of the dictionaries needed to support recursive by-name implicit arguments requires trees to be hoisted out of the arguments as they are elaborated. Moving trees around in this way has always been a delicate operation because of the need to maintain correct owner chains. Inlining and the position checking phase added in 69cf220 complicates this still further because we now have to make the source associated with the hoisted tree match the checkers expectations after it has been moved. This is done by reusing the repositioning logic from the inliner. The issue this commit fixes only shows up in cases where an inline method defined is used as part of a by-name implicit argument resolution in a different source file.
nicolasstucki
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The construction of the dictionaries needed to support recursive by-name implicit arguments requires trees to be hoisted out of the arguments as they are elaborated. Moving trees around in this way has always been a delicate operation because of the need to maintain correct owner chains.
Inlining and the position checking phase added in 69cf220 complicates this still further because we now have to make the source associated with the hoisted tree match the checkers expectations after it has been moved. This is done by reusing the repositioning logic from the inliner.
The issue this commit fixes only shows up in cases where an inline method is used as part of a by-name implicit argument resolution in a different source file.